[autobackport: sssd-2-9] ipa trust bugfix and improvement of handling unknown trust type error#8274
Conversation
There was a problem hiding this comment.
Code Review
This pull request backports two important fixes for IPA trust handling. The first change corrects a copy-paste error in a conditional, ensuring that IPA_TRUST_IPA is handled correctly. This is a critical fix for the logic. The second change improves error handling for unknown trust types by returning a more appropriate error code (EINVAL) and enhancing the debug message, which improves robustness and debuggability. The changes are correct and well-implemented. I have no further recommendations.
|
|
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit f2e8e51)
If trust type is unknown for an IPA subdomain request, return EINVAL instead of ENOMEM, and improve the logged error message. Trust type should always be IPA_TRUST_IPA, or IPA_TRUST_AD, if trust discovery and initialization fails early on we can reach this codepath however. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit 50527dc)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
b023162 to
09c103d
Compare
This is an automatic backport of PR#8258 ipa trust bugfix and improvement of handling unknown trust type error to branch sssd-2-9, created by @justin-stephenson.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
f2e8e51 - ipa: Fix typo in trust type conditional
50527dc - ipa: improve unknown trust type error return
Backported commits
Original Pull Request Body