ipa: check for empty trusts in ipa_get_trust_type()#8254
Merged
alexey-tikhonov merged 1 commit intoSSSD:masterfrom Dec 2, 2025
Merged
ipa: check for empty trusts in ipa_get_trust_type()#8254alexey-tikhonov merged 1 commit intoSSSD:masterfrom
alexey-tikhonov merged 1 commit intoSSSD:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a potential NULL pointer dereference in ipa_get_trust_type. When the trust list is empty or no matching trust is found, the original code would attempt to dereference a NULL or uninitialized pointer, leading to a crash. The added check ensures the function safely returns IPA_TRUST_UNKNOWN in such cases, which is the correct behavior and consistent with similar functions in the codebase. This is an important fix for stability.
alexey-tikhonov
approved these changes
Dec 2, 2025
Member
|
Note: no new issues reported by Covcan. |
Similar as ipa_get_ad_id_ctx() or ipa_get_ipa_id_ctx() ipa_get_trust_type() should be aware that the 'trusts' member of 'server_mode' might be NULL. Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Contributor
616beb1 to
648af6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar as ipa_get_ad_id_ctx() or ipa_get_ipa_id_ctx() ipa_get_trust_type() should be aware that the 'trusts' member of 'server_mode' might be NULL.