Skip to content

CONFIG: disable 'session_provider' by default#8250

Merged
sumit-bose merged 1 commit intoSSSD:masterfrom
alexey-tikhonov:session_provider
Dec 3, 2025
Merged

CONFIG: disable 'session_provider' by default#8250
sumit-bose merged 1 commit intoSSSD:masterfrom
alexey-tikhonov:session_provider

Conversation

@alexey-tikhonov
Copy link
Member

:config: Default value of 'session_provider' option was changed to 'none' (i.e. disabled) doesn't matter what 'id_provider' used. Previously 'session_provider' was enabled by default for 'id_provider = ipa' case. But this didn't make sense because 'Fleet Commander', that is being integrated in this case, is long time obsolete.

@alexey-tikhonov alexey-tikhonov force-pushed the session_provider branch 2 times, most recently from b1c3269 to ae5bb69 Compare November 28, 2025 15:52
@alexey-tikhonov alexey-tikhonov marked this pull request as ready for review November 28, 2025 16:24
@alexey-tikhonov
Copy link
Member Author

(rebased)

@sumit-bose
Copy link
Contributor

Hi,

do you think it would make sense to add a ":relnote:" tag as well, in case there is still somebody out there using the fleet commander feature?

bye,
Sumit

@alexey-tikhonov
Copy link
Member Author

do you think it would make sense to add a ":relnote:" tag as well, in case there is still somebody out there using the fleet commander feature?

There is :config: note, it will also get to 'release notes', just a different section.
I don't think it's possible to tag the same note with two different tags.
Do you think it's worth two different notes in different sections?

@sumit-bose
Copy link
Contributor

do you think it would make sense to add a ":relnote:" tag as well, in case there is still somebody out there using the fleet commander feature?

There is :config: note, it will also get to 'release notes', just a different section. I don't think it's possible to tag the same note with two different tags. Do you think it's worth two different notes in different sections?

Ok, thanks.

Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the patch, worked as expected in my tests, ACK.

bye,
Sumit

:config: Default value of 'session_provider' option was changed to 'none'
(i.e. disabled) doesn't matter what 'id_provider' used. Previously
'session_provider' was enabled by default for 'id_provider = ipa' case.
But this didn't make sense because 'Fleet Commander', that is being
integrated in this case, is long time obsolete.

Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
@sssd-bot
Copy link
Contributor

sssd-bot commented Dec 3, 2025

The pull request was accepted by @sumit-bose with the following PR CI status:


🟢 CodeFactor (success)
🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-41-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-41) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-41) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sumit-bose sumit-bose merged commit 2a1048b into SSSD:master Dec 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants