Skip to content

intg: remove test_session_recording.py#8243

Merged
spoore1 merged 1 commit intoSSSD:masterfrom
spoore1:rm_intg_session_recording
Dec 4, 2025
Merged

intg: remove test_session_recording.py#8243
spoore1 merged 1 commit intoSSSD:masterfrom
spoore1:rm_intg_session_recording

Conversation

@spoore1
Copy link
Contributor

@spoore1 spoore1 commented Nov 26, 2025

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes test_session_recording.py, which appears to be the complete integration test suite for the SSSD session recording feature. Based on other files in the repository such as src/man/sssd-session-recording.5.xml and src/util/session_recording.c, this feature is still active. Deleting its tests introduces a critical risk of regressions going undetected. It is essential to maintain test coverage for existing features. If these tests are being replaced, the new tests should ideally be part of the same pull request.

@spoore1 spoore1 force-pushed the rm_intg_session_recording branch from f3bbebb to b55b9d4 Compare November 26, 2025 14:19
@danlavu
Copy link

danlavu commented Dec 3, 2025

(.venv)  dlavu@rocket  ~/git/sssd   master  git_exists.sh src/tests/intg/test_session_recording.py
FILE FOUND →  master
FILE FOUND →  sssd-2-10
FILE FOUND →  sssd-2-11
FILE FOUND →  sssd-2-7
FILE FOUND →  sssd-2-8
FILE FOUND →  sssd-2-9
FILE FOUND →  sssd-2-9-4

Adding the necessary tag, but AFAIK, we are leaving 2-7 and 2-8 alone.

@danlavu danlavu self-assigned this Dec 3, 2025
@danlavu danlavu self-requested a review December 3, 2025 17:08
@danlavu
Copy link

danlavu commented Dec 3, 2025

This has been discussed, the priority to remove these tests are greater than having these intg tests. These tests will be written for the new test framework at a later time.

Removing intg session recording test file and removing from Makefile.

Reviewed-by: Dan Lavu <dlavu@redhat.com>
@sssd-bot
Copy link
Contributor

sssd-bot commented Dec 3, 2025

The pull request was accepted by @spoore1 with the following PR CI status:


🟢 CodeFactor (success)
🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-41-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🔴 ci / intgcheck (centos-10) (failure)
🟢 ci / intgcheck (fedora-41) (success)
🔴 ci / intgcheck (fedora-42) (failure)
🔴 ci / intgcheck (fedora-43) (failure)
🔴 ci / intgcheck (fedora-44) (failure)
🟢 ci / prepare (success)
🟢 ci / system (centos-10) (success)
🟢 ci / system (fedora-41) (success)
🟢 ci / system (fedora-42) (success)
🟢 ci / system (fedora-43) (success)
🟢 ci / system (fedora-44) (success)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the rm_intg_session_recording branch from b55b9d4 to fbdd22a Compare December 3, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants