Skip to content

[autobackport: sssd-2-9] fixing and making automatic kcm renewal test more forgiving#8232

Merged
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8183-to-sssd-2-9
Nov 25, 2025
Merged

[autobackport: sssd-2-9] fixing and making automatic kcm renewal test more forgiving#8232
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8183-to-sssd-2-9

Conversation

@sssd-bot
Copy link
Contributor

This is an automatic backport of PR#8183 fixing and making automatic kcm renewal test more forgiving to branch sssd-2-9, created by @danlavu.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8183-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8183-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8183-to-sssd-2-9 --force

Original commits
fc159ed - fixing and making automatic kcm renewal test more foriving

Backported commits

  • a7d0833 - fixing and making automatic kcm renewal test more foriving

Original Pull Request Body

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Scott Poore <spoore@redhat.com>
(cherry picked from commit fc159ed)
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a flaky test related to KCM ticket renewal by increasing a sleep duration. While this change makes the test more lenient and likely to pass under normal conditions, I've pointed out that it doesn't fully resolve an underlying race condition. I've provided a comment explaining the issue and suggesting a more robust fix to improve test stability.

@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. Accepted labels Nov 25, 2025
@alexey-tikhonov alexey-tikhonov removed the request for review from spoore1 November 25, 2025 08:11
@sssd-bot
Copy link
Contributor Author

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 ci / prepare (success)
🔴 ci / system (centos-9) (failure)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@alexey-tikhonov alexey-tikhonov merged commit 5d6303c into SSSD:sssd-2-9 Nov 25, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants