adding subid test by danlavu · Pull Request #8225 · SSSD/sssd

danlavu · 2025-11-22T06:49:20Z

No description provided.

gemini-code-assist

Code Review

This pull request adds a new system test for subid configuration in IPA. My review focuses on the new test case, where I've found several copy-paste errors in the assertions that would cause the test to fail or report incorrect information. I've provided suggestions to fix the incorrect function calls and assertion messages.

src/tests/system/tests/test_ipa.py

danlavu · 2025-11-22T06:56:10Z

This requires two other PRs.

adding subid management to the ipa role sssd-test-framework#221 , framework
adding shadow-utils-subid package sssd-ci-containers#154 , installing the shadow-utils-subid package

jakub-vavra-cz

LGTM

src/tests/system/tests/test_ipa.py

alexey-tikhonov · 2025-11-24T15:20:25Z

src/tests/system/tests/test_ipa.py

+    ), f"Subordinate UID start range {uid.range_start} does not match: {subid.uid_start}!"
+    assert (
+        subid.uid_size == uid.range_size
+    ), f"Subordinate UID start range {uid.range_size} does not match: {subid.uid_size}!"


Copy-paste error.

It's correct, but I think it's from the confusing variable names and attributes.

subid from ipa has four attributes

subid.uid_size

subid.uid_range

subid.gid_size

subid.gid_range

tools.getsubids, returns two

range_size

range_start

subid.uid_size == object.range_size
subid.uid_start == object.range_start

subid.gid_size == group_object.range_size
subid.gid_start == group_object.range_start

The variables have been changed, let me know if it's still confusing.

The text itself - "Subordinate UID start range" - was a copy&paste error.

Text says "UID start range" but prints "{uid.range_size}".

My mistake, fixed.

alexey-tikhonov · 2025-11-24T15:20:33Z

src/tests/system/tests/test_ipa.py

+    ), f"Subordinate GID start range {gid.range_start} does not match: {subid.gid_start}!"
+    assert (
+        subid.gid_size == gid.range_size
+    ), f"Subordinate GID start range {gid.range_size} does not match: {subid.gid_size}!"


Copy-paste error.

src/tests/system/tests/test_ipa.py

alexey-tikhonov · 2025-12-02T12:42:01Z

@danlavu, mypy fails:

tests/test_ipa.py:671: error: Item "None" of "SubIDEntry | None" has no attribute "range_start"  [union-attr]
tests/test_ipa.py:673: error: Item "None" of "SubIDEntry | None" has no attribute "range_size"  [union-attr]
tests/test_ipa.py:674: error: Item "None" of "SubIDEntry | None" has no attribute "range_size"  [union-attr]
tests/test_ipa.py:679: error: Item "None" of "SubIDEntry | None" has no attribute "range_start"  [union-attr]
tests/test_ipa.py:680: error: Item "None" of "SubIDEntry | None" has no attribute "range_start"  [union-attr]
tests/test_ipa.py:682: error: Item "None" of "SubIDEntry | None" has no attribute "range_size"  [union-attr]
tests/test_ipa.py:683: error: Item "None" of "SubIDEntry | None" has no attribute "range_size"  [union-attr]
Found 8 errors in 1 file (checked 33 source files)

alexey-tikhonov · 2025-12-03T09:42:39Z

Note:

tests/test_ipa.py::test_ipa__subids_configured (ipa) PASSED              [ 22%]

alexey-tikhonov · 2025-12-03T09:48:16Z

@jakub-vavra-cz, are you fine with the latest version?

alexey-tikhonov · 2025-12-03T09:49:01Z

I set 'Blocked' until patch "do not add this commit" removed.

alexey-tikhonov · 2025-12-03T09:49:59Z

SSSD/sssd-test-framework#221 was merged.

jakub-vavra-cz

lgtm

danlavu requested a review from alexey-tikhonov November 22, 2025 06:49

danlavu assigned alexey-tikhonov Nov 22, 2025

danlavu added Waiting for review Tests backport-to-sssd-2-10 backport-to-sssd-2-11 labels Nov 22, 2025

gemini-code-assist bot reviewed Nov 22, 2025

View reviewed changes

src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved

src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved

src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved

danlavu force-pushed the tests-subid branch 2 times, most recently from d731c99 to 64194c5 Compare November 22, 2025 06:54

danlavu requested a review from jakub-vavra-cz November 22, 2025 06:55

danlavu assigned jakub-vavra-cz Nov 22, 2025

jakub-vavra-cz approved these changes Nov 24, 2025

View reviewed changes

alexey-tikhonov reviewed Nov 24, 2025

View reviewed changes

src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved

alexey-tikhonov reviewed Nov 24, 2025

View reviewed changes

src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved

alexey-tikhonov reviewed Nov 24, 2025

View reviewed changes

src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved

alexey-tikhonov reviewed Nov 24, 2025

View reviewed changes

alexey-tikhonov added Changes requested backport-to-sssd-2-9 backport-to-sssd-2-9-4 Corresponds to C8S and removed Waiting for review backport-to-sssd-2-10 backport-to-sssd-2-11 labels Nov 24, 2025

danlavu force-pushed the tests-subid branch from 64194c5 to 96c6295 Compare November 24, 2025 16:32

danlavu requested a review from alexey-tikhonov November 24, 2025 16:32

danlavu force-pushed the tests-subid branch from 96c6295 to 1a1df6e Compare November 24, 2025 16:40

alexey-tikhonov reviewed Nov 24, 2025

View reviewed changes

src/tests/system/tests/test_ipa.py Outdated Show resolved Hide resolved

danlavu force-pushed the tests-subid branch 2 times, most recently from d09a147 to 2724d2c Compare December 1, 2025 19:07

danlavu force-pushed the tests-subid branch from 2724d2c to 7d2179f Compare December 1, 2025 19:49

danlavu force-pushed the tests-subid branch 2 times, most recently from 8b19216 to ce3167e Compare December 2, 2025 21:29

alexey-tikhonov added Waiting for review and removed Changes requested labels Dec 3, 2025

alexey-tikhonov approved these changes Dec 3, 2025

View reviewed changes

alexey-tikhonov requested a review from jakub-vavra-cz December 3, 2025 09:48

alexey-tikhonov added Blocked and removed Waiting for review labels Dec 3, 2025

danlavu force-pushed the tests-subid branch from ce3167e to c3ad11e Compare December 5, 2025 18:07

alexey-tikhonov removed the Blocked label Dec 8, 2025

danlavu force-pushed the tests-subid branch 3 times, most recently from 2fe4b25 to 42995ba Compare December 9, 2025 19:04

adding subid test

deac075

danlavu force-pushed the tests-subid branch from 42995ba to deac075 Compare December 9, 2025 19:05

jakub-vavra-cz approved these changes Dec 10, 2025

View reviewed changes

danlavu merged commit 449913a into SSSD:master Dec 10, 2025
23 of 24 checks passed

This was referenced Dec 10, 2025

[autobackport: sssd-2-9] adding subid test #8294

Open

[autobackport: sssd-2-9-4] adding subid test #8295

Closed

danlavu deleted the tests-subid branch January 23, 2026 14:43

danlavu restored the tests-subid branch January 27, 2026 03:24

Conversation

danlavu commented Nov 22, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danlavu commented Nov 22, 2025

Uh oh!

jakub-vavra-cz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexey-tikhonov Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

danlavu Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

alexey-tikhonov Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

alexey-tikhonov Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

danlavu Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

alexey-tikhonov Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

danlavu Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexey-tikhonov commented Dec 2, 2025

Uh oh!

alexey-tikhonov commented Dec 3, 2025

Uh oh!

alexey-tikhonov commented Dec 3, 2025

Uh oh!

alexey-tikhonov commented Dec 3, 2025

Uh oh!

alexey-tikhonov commented Dec 3, 2025

Uh oh!

jakub-vavra-cz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants