Skip to content

[autobackport: sssd-2-9] man: Clarify the user_attributes option#8208

Merged
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8193-to-sssd-2-9
Nov 18, 2025
Merged

[autobackport: sssd-2-9] man: Clarify the user_attributes option#8208
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
sssd-bot:SSSD-sssd-backport-pr8193-to-sssd-2-9

Conversation

@sssd-bot
Copy link
Contributor

@sssd-bot sssd-bot commented Nov 18, 2025

This is an automatic backport of PR#8193 man: Clarify the user_attributes option to branch sssd-2-9, created by @justin-stephenson.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8193-to-sssd-2-9
git checkout SSSD-sssd-backport-pr8193-to-sssd-2-9
git push sssd-bot SSSD-sssd-backport-pr8193-to-sssd-2-9 --force

Original commits
984d794 - man: Clarify the user_attributes option

Backported commits

  • 45d936b - man: Clarify the user_attributes option

Original Pull Request Body

Resolves: #8134

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 18, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automatic backport that clarifies the user_attributes option in the sssd-ifp man page. The changes specify that the option applies only to the Users D-Bus interface and not the deprecated GetUserAttr interface, and that added attributes are exposed via the extraAttributes property. These documentation improvements are clear and appear correct based on the provided context. I have not identified any issues with these changes.

@alexey-tikhonov alexey-tikhonov removed the request for review from sumit-bose November 18, 2025 12:11
@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Nov 18, 2025

Ci failure not related.

@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. Accepted labels Nov 18, 2025
@justin-stephenson @sssd-bot
man: Clarify the user_attributes option
fcc01b2 
Resolves: SSSD#8134
Reviewed-by:
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
(cherry picked from commit 984d794)
@sssd-bot
Copy link
Contributor Author

sssd-bot commented Nov 18, 2025

The pull request was accepted by @alexey-tikhonov with the following PR CI status:

🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / make-distcheck (success)
🟢 ci / prepare (success)
🔴 ci / system (centos-9) (failure)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8193-to-sssd-2-9 branch from 45d936b to fcc01b2 Compare November 18, 2025 14:39
@alexey-tikhonov alexey-tikhonov merged commit 7c2edd8 into SSSD:sssd-2-9 Nov 18, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-tikhonov alexey-tikhonov alexey-tikhonov approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alexey-tikhonov alexey-tikhonov

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sssd-bot @alexey-tikhonov @sumit-bose @justin-stephenson