Tests: Add umockdev and virtsmarcard as test dependencies#8165
Tests: Add umockdev and virtsmarcard as test dependencies#8165alexey-tikhonov merged 1 commit intoSSSD:sssd-2-9from
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds umockdev and virtualsmartcard as test dependencies to skip tests automatically when the environment is not available. The changes are generally good, but I've found a few issues in the newly added tests in test_passkey.py. There is a critical syntax error in a pytest marker, a missing import for the re module, and several tests are missing the umockdev dependency in their builtwith marker. These issues will cause tests to fail or not behave as expected. Please see my detailed comments for suggestions on how to fix them.
70ce229 to
949ce8e
Compare
krishnavema
left a comment
There was a problem hiding this comment.
Overall Looks Good To Me
We want to skip these tests automatically if they do not have the required environment available instead of manually blacklisting them from test suites. Reviewed-by: Dan Lavu <dlavu@redhat.com> Reviewed-by: Vema Kudumala <vkudumal@redhat.com> Reviewed-by:
|
The pull request was accepted by @jakub-vavra-cz with the following PR CI status: 🟢 CodeQL (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
949ce8e to
01b1151
Compare
We want to skip these tests automatically if they do not have the required environment available instead of manually blacklisting them from test suites.
Reviewed-by: Dan Lavu dlavu@redhat.com
Reviewed-by: Vema Kudumala vkudumal@redhat.com