Skip to content

Test migration sssctl#8114

Merged
alexey-tikhonov merged 2 commits intoSSSD:masterfrom
thalman:test_migration_sssctl
Nov 25, 2025
Merged

Test migration sssctl#8114
alexey-tikhonov merged 2 commits intoSSSD:masterfrom
thalman:test_migration_sssctl

Conversation

@thalman
Copy link
Contributor

@thalman thalman commented Sep 26, 2025

This is a bunch of sssctl tests migrated using AI.

The commits are not rebased to show what hel AI provided.

@thalman thalman requested a review from danlavu September 26, 2025 16:37
@thalman thalman marked this pull request as ready for review October 1, 2025 07:54
danlavu
danlavu requested changes Oct 3, 2025
View reviewed changes
@alexey-tikhonov alexey-tikhonov self-requested a review October 9, 2025 12:45
@alexey-tikhonov alexey-tikhonov self-assigned this Oct 9, 2025
danlavu
danlavu reviewed Oct 10, 2025
View reviewed changes
@thalman thalman force-pushed the test_migration_sssctl branch from 7e0c405 to 4d9481b Compare November 3, 2025 10:38
@thalman
Copy link
Contributor Author

thalman commented Nov 3, 2025

Blocked by SSSD/sssd-test-framework#216

@thalman thalman added the Blocked label Nov 3, 2025
@thalman thalman force-pushed the test_migration_sssctl branch 6 times, most recently from d970a6e to c86b531 Compare November 3, 2025 15:15
@thalman thalman removed the Blocked label Nov 3, 2025
@thalman
Copy link
Contributor Author

thalman commented Nov 3, 2025 •
edited
Loading

Hi guys, I believe that this is ready for second round. We can merge it and I will create followup PR with client.sssctl.group_show() once SSSD/sssd-test-framework#216 is merged.

@thalman thalman force-pushed the test_migration_sssctl branch from c86b531 to 63688fb Compare November 3, 2025 19:50
@thalman
Copy link
Contributor Author

thalman commented Nov 3, 2025

Hi guys, I believe that this is ready for second round. We can merge it and I will create followup PR with client.sssctl.group_show() once SSSD/sssd-test-framework#216 is merged.

I realized that group_show() is already implemented. Sorry for confusion. PR updated.

@pbrezina pbrezina force-pushed the master branch 2 times, most recently from f5d64b3 to b854636 Compare November 4, 2025 14:27
@thalman thalman force-pushed the test_migration_sssctl branch from 63688fb to 4215930 Compare November 12, 2025 09:35
@thalman
Copy link
Contributor Author

thalman commented Nov 12, 2025 •
edited
Loading

@alexey-tikhonov, @danlavu, I rebased the PR. It is ready for second review.

danlavu
danlavu approved these changes Nov 12, 2025
View reviewed changes
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, minor nitpick comments.

danlavu
danlavu approved these changes Nov 19, 2025
View reviewed changes
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aborah-sudo aborah-sudo mentioned this pull request Nov 21, 2025
Closed
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
alexey-tikhonov
alexey-tikhonov reviewed Nov 21, 2025
View reviewed changes
@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Nov 21, 2025

Overall looks good but I have some comments / questions - see inline.

@thalman thalman force-pushed the test_migration_sssctl branch from b07030e to 432fbf5 Compare November 24, 2025 15:38
@thalman thalman force-pushed the test_migration_sssctl branch from 432fbf5 to eed4e62 Compare November 24, 2025 20:35
@thalman
Copy link
Contributor Author

thalman commented Nov 24, 2025

I force pushed change fixing last @alexey-tikhonov 's comments about test_sssctl__debug_level_component

let a comment here if you are fine with that.

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Nov 25, 2025

let a comment here if you are fine with that.

ACK

@thalman @sssd-bot
tests: Remove obsolete sssctl tests
53827dc 
Those tests are now covered in new testing framework.

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Dan Lavu <dlavu@redhat.com>
@thalman @sssd-bot
tests: migrate sssctl tests to new framework
76ca67e 
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Dan Lavu <dlavu@redhat.com>
@sssd-bot
Copy link
Contributor

sssd-bot commented Nov 25, 2025

The pull request was accepted by @alexey-tikhonov with the following PR CI status:

🟢 CodeFactor (success)
🟢 CodeQL (success)
🟢 osh-diff-scan:fedora-rawhide-x86_64:upstream (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-41-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 Analyze (target) / cppcheck (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)
🟢 ci / intgcheck (centos-10) (success)
🟢 ci / intgcheck (fedora-41) (success)
🟢 ci / intgcheck (fedora-42) (success)
🟢 ci / intgcheck (fedora-43) (success)
🟢 ci / intgcheck (fedora-44) (success)
🟢 ci / prepare (success)
🟡 ci / system (centos-10) (in_progress)
🟢 ci / system (fedora-41) (success)
🟢 ci / system (fedora-42) (success)
🔴 ci / system (fedora-43) (failure)
🔴 ci / system (fedora-44) (failure)
➖ Coverity scan / coverity (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)

There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the test_migration_sssctl branch from eed4e62 to 76ca67e Compare November 25, 2025 09:49
@alexey-tikhonov alexey-tikhonov merged commit cf974c6 into SSSD:master Nov 25, 2025
11 of 16 checks passed
This was referenced Nov 25, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danlavu danlavu danlavu approved these changes

@alexey-tikhonov alexey-tikhonov alexey-tikhonov approved these changes

Assignees

@danlavu danlavu

@alexey-tikhonov alexey-tikhonov

Labels

Accepted backport-to-sssd-2-9-4 Corresponds to C8S backport-to-sssd-2-9 backport-to-sssd-2-10 backport-to-sssd-2-11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thalman @alexey-tikhonov @sssd-bot @danlavu