Skip to content

997 integrate google cast into the demo #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 15 commits into from
Apr 29, 2025
Merged

997 integrate google cast into the demo #998

MGaetan89 merged 15 commits into from
Apr 29, 2025

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Apr 25, 2025 •
edited
Loading

Pull request

Description

The goal of this PR is to move the pillarbox-demo-cast into pillarbox-demo. A new showcase is available in the tab Showcases into the section integrations.

It also add an application settings to configure the application receiver id.

Capture d’écran 2025-04-28 à 09 16 02

Changes made

  • Delete pillarbox-demo-cast
  • Add Google Cast showcase to the demo.
  • Add options to configure the cast receiver application id.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Apr 25, 2025 that may be closed by this pull request
Integrate Google cast into the Demo #997
Closed
2 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Apr 25, 2025
@github-actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

Code Coverage

Overall Project 50.8% 🟢

There is no coverage information present for the Files changed

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 25, 2025
View reviewed changes
@StaehliJ StaehliJ requested a review from MGaetan89 April 28, 2025 07:18
@MGaetan89 MGaetan89 added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit aa8f7d2 Apr 29, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the 997-integrate-google-cast-into-the-demo branch April 29, 2025 12:38
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate Google cast into the Demo

2 participants

@StaehliJ @MGaetan89