Skip to content

override default method as they are not implement by delegation #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 3 commits into from
Apr 16, 2025
Merged

override default method as they are not implement by delegation #992

StaehliJ merged 3 commits into from
Apr 16, 2025

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Apr 15, 2025 •
edited
Loading

Pull request

Description

Media3 changes some method from ExoPlayer interface and as we use implements delegation, it doesn't work.

Changes made

  • Implements default method and forward it to real implementation

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Apr 15, 2025
@github-actions
Copy link

github-actions bot commented Apr 15, 2025 •
edited
Loading

Code Coverage

Overall Project 50.74% -0.01% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-player 57.04% -0.03% 🟢
Files
Module File Coverage
:pillarbox-player PillarboxExoPlayer.kt 70.68% -0.58% 🟢

@StaehliJ StaehliJ requested a review from MGaetan89 April 15, 2025 13:08
@StaehliJ StaehliJ changed the title override default method as they are not implement with "by" override default method as they are not implement by delegation Apr 15, 2025
@MGaetan89
Copy link
Contributor

MGaetan89 commented Apr 15, 2025

Maybe we could add a test similar to this one to automatically catch missing implementations?

@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Apr 16, 2025
@StaehliJ StaehliJ enabled auto-merge April 16, 2025 09:18
MGaetan89
MGaetan89 approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

@StaehliJ StaehliJ added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit ba83b2a Apr 16, 2025
10 checks passed
@StaehliJ StaehliJ deleted the overrides-default-from-interface branch April 16, 2025 11:52
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StaehliJ StaehliJ

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StaehliJ @MGaetan89