Skip to content

Add the VPN blocking reason #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 3 commits into from
Apr 29, 2025
Merged

Add the VPN blocking reason #985

StaehliJ merged 3 commits into from
Apr 29, 2025

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Apr 11, 2025 •
edited
Loading

Description

This PR adds support for the VPN blocking reason.

Changes made

  • Add the VPN blocking reason.
  • Add the corresponding VPN exception.
  • Add the corresponding translations.
  • Update the tests.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 linked an issue Apr 11, 2025 that may be closed by this pull request
Add VPN blocking reason #977
Closed
2 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Apr 11, 2025
@github-actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

Code Coverage

Overall Project 50.8% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-core-business 77.91% 🟢
Files
Module File Coverage
:pillarbox-core-business BlockReason.kt 100% 🟢
BlockReasonException.kt 100% 🟢
Chapter.kt 93.85% 🟢

@MGaetan89 MGaetan89 force-pushed the 977-add-vpn-blocking-reason branch from d43922c to 376bb50 Compare April 14, 2025 07:44
@MGaetan89 MGaetan89 force-pushed the 977-add-vpn-blocking-reason branch from c060a71 to faa2881 Compare April 28, 2025 09:23
@MGaetan89 MGaetan89 marked this pull request as ready for review April 28, 2025 09:35
@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Apr 28, 2025

@StaehliJ this can be reviewed now

@StaehliJ StaehliJ added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit f37c829 Apr 29, 2025
10 checks passed
@StaehliJ StaehliJ deleted the 977-add-vpn-blocking-reason branch April 29, 2025 11:20
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add VPN blocking reason

2 participants

@MGaetan89 @StaehliJ