Skip to content

982 handle multi period #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 8 commits into from
Apr 16, 2025
Merged

982 handle multi period #984

MGaetan89 merged 8 commits into from
Apr 16, 2025

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Apr 11, 2025

Pull request

Description

Fix crash when multi period stream is playing.

Changes made

  • indexOfPeriod isn't used to fetch a Window in the Timeline.
  • Add more properties to DemoItem.URL to customize DrmConfig.
  • Add some multi period DashIf streams into the demo.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Apr 11, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 April 11, 2025 09:17
@github-actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

Code Coverage

Overall Project 50.79% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-player 57.12% 🟢
Files
Module File Coverage
:pillarbox-player PlaybackSessionManager.kt 92.97% 🟢
Monitoring.kt 88.73% 🟢

@MGaetan89 MGaetan89 linked an issue Apr 11, 2025 that may be closed by this pull request
Player crash when playing multi period stream #982
Closed
1 task
@StaehliJ StaehliJ requested a review from MGaetan89 April 16, 2025 08:27
@MGaetan89 MGaetan89 added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 4bfaa24 Apr 16, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the 982-handle-multi-period branch April 16, 2025 11:49
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Player crash when playing multi period stream

2 participants

@StaehliJ @MGaetan89