Skip to content

Align naming with Apple and commandersAct dashboard #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 3 commits into from
Apr 4, 2025
Merged

Align naming with Apple and commandersAct dashboard #976

StaehliJ merged 3 commits into from
Apr 4, 2025

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Apr 3, 2025 •
edited
Loading

Pull request

Description

This PR renames commanders act source key enum names to match the name from apple and commanders act dashboard.

Changes made

  • Rename SourceKey.SRG_PROD to SourceKey.PRODUTION.
  • Rename SourceKey.SRG_DEBUG to SourceKey.DEVELOPMENT.
  • Remove depreciated symbols AnalyticsConfig.SOURCE_KEY_SRG_PROD and AnalyticsConfig.SOURCE_KEY_SRG_DEBUG.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Apr 3, 2025 that may be closed by this pull request
SourceKey for Development #972
Closed
2 tasks
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Apr 3, 2025
@StaehliJ StaehliJ requested a review from Gustl22 April 3, 2025 08:34
@github-actions
Copy link

github-actions bot commented Apr 3, 2025 •
edited
Loading

Code Coverage

Overall Project 50.75% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-analytics 87.71% 🟢
Files
Module File Coverage
:pillarbox-analytics AnalyticsConfig.kt 100% 🟢
SourceKey.kt 100% 🟢
SRGAnalytics.kt 48.95% 🟢

@Gustl22
Copy link

Gustl22 commented Apr 3, 2025

We also adapt the two occurances README probably?

pillarbox-android/pillarbox-analytics/docs/README.md

Line 34 in cd1b5ba

sourceKey = SourceKey.SRG_DEBUG,

@StaehliJ StaehliJ requested a review from MGaetan89 April 3, 2025 13:51
Gustl22
Gustl22 approved these changes Apr 4, 2025
View reviewed changes
Copy link

@Gustl22 Gustl22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ;D thanks

@StaehliJ StaehliJ added this pull request to the merge queue Apr 4, 2025
Merged via the queue into main with commit ab794b7 Apr 4, 2025
10 checks passed
@StaehliJ StaehliJ deleted the 972-sourcekey-for-development branch April 4, 2025 07:02
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gustl22 Gustl22 Gustl22 approved these changes

+1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SourceKey for Development

3 participants

@StaehliJ @Gustl22 @MGaetan89