Skip to content

Fix urn to be DemoItem.URN instead of URL #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 1 commit into from
Mar 28, 2025
Merged

Fix urn to be DemoItem.URN instead of URL #963

StaehliJ merged 1 commit into from
Mar 28, 2025

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Mar 28, 2025

Pull request

Description

Some DemoItem that plays urn still are DemoItem.URL

Changes made

  • Self-explanatory

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Mar 28, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 March 28, 2025 10:07
@github-actions
Copy link

github-actions bot commented Mar 28, 2025

Code Coverage

Overall Project 50.77% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 moved this from 📋 Backlog to 🍿 Code Review in Pillarbox Mar 28, 2025
@MGaetan89 MGaetan89 added the bug Something isn't working label Mar 28, 2025
@MGaetan89 MGaetan89 added this to the Demo milestone Mar 28, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit 692aba1 Mar 28, 2025
10 checks passed
@StaehliJ StaehliJ deleted the fix-demo-item branch March 28, 2025 14:37
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StaehliJ StaehliJ

Labels

bug Something isn't working

Projects

Pillarbox
Status: ✅ Done

Milestone

Demo

Development

Successfully merging this pull request may close these issues.

2 participants

@StaehliJ @MGaetan89