Skip to content

Conversation

@MGaetan89
Copy link
Contributor

Pull request

Description

This commit fixes the rollback job in the release workflow.
It also disables documentation publication for snapshot releases.

Changes made

  • Create a new delete_package.sh script to be able to delete a package by version.
  • Update the release.yml workflow to use that script during the rollback job to delete the published packages.
  • Extract the pre-release logic into its own job so its output can be used in other jobs.
  • Fix the Create GitHub Release job to properly set the prerelease flag.
  • Don't publish documentation for prerelease versions.

Additional information

Delete packages

The delete_package.sh script can be used outside the GitHub Action by running it from the command line:

./delete_package.sh SRGSSR ch.srgssr.pillarbox.pillarbox-analytics 6.0.0

It only looks for the version in the last 30 versions returned by the API. Deleting an older version won't work out of the box with this script.

Pre-release check

You can see the result of a pre-release here (6.0.0-SNAPSHOT) and a release here (6.0.0).

(the publications and Firebase jobs fail because credentials are missing in my fork)

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 linked an issue Mar 20, 2025 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Mar 20, 2025
@MGaetan89 MGaetan89 requested a review from StaehliJ March 20, 2025 10:29
@github-actions
Copy link

Code Coverage

Overall Project 51.38% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 543161f Mar 20, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the 945-fix-the-rollback-step-of-the-release-workflow branch March 20, 2025 15:33
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Fix the rollback step of the release workflow

2 participants