Skip to content

Fix potential race condition with heartbeat #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 1 commit into from
Mar 20, 2025
Merged

Fix potential race condition with heartbeat #950

MGaetan89 merged 1 commit into from
Mar 20, 2025

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Mar 19, 2025 •
edited
Loading

Pull request

Description

Heartbeat are running into a separate thread it is possible to trigger a heartbeat even after the heartbeat as been stopped.

Changes made

  • Monitoring heartbeat is send only if the current item exist and it is current.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ
Fix potential race condition with heartbeat
19170c2 
Heartbeat are running into a separate thread it is possible to trigger a heartbeat even after the heartbeat as been stopped.
@StaehliJ StaehliJ linked an issue Mar 19, 2025 that may be closed by this pull request
Sport Live stream sporadically crash #949
Closed
1 task
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Pillarbox Mar 19, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 March 20, 2025 08:41
@github-actions
Copy link

github-actions bot commented Mar 20, 2025

Code Coverage

Overall Project 51.42% 🟢
Files changed 98.63% 🟢

Module Coverage
:pillarbox-player 57.32% -0.01% 🟢
Files
Module File Coverage
:pillarbox-player Monitoring.kt 88.85% -0.1% 🟢

@StaehliJ StaehliJ added this pull request to the merge queue Mar 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 20, 2025
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 12723cb Mar 20, 2025
15 checks passed
@MGaetan89 MGaetan89 deleted the 949-improve-stability-monitoring branch March 20, 2025 15:43
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MGaetan89 MGaetan89

@chjaeggi chjaeggi

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sport Live stream sporadically crash

3 participants

@StaehliJ @MGaetan89 @chjaeggi