Skip to content

Add application information and audio/subtitles language to monitoring events #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 1 commit into from
Mar 13, 2025
Merged

Add application information and audio/subtitles language to monitoring events #941

MGaetan89 merged 1 commit into from
Mar 13, 2025

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Mar 12, 2025

Pull request

Description

This commit updates the monitoring models to include more information, based on the latest update of the specification.

Changes made

  • Adds application id and version to Session.
  • Adds audio and subtitles information to EventMessageData and ErrorMessageData.
  • Removes unused origin field from Session.Media.
  • Adds unit tests for the above.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Mar 12, 2025
@MGaetan89 MGaetan89 linked an issue Mar 12, 2025 that may be closed by this pull request
Add track and application information to monitoring data #926
Closed
3 tasks
@github-project-automation github-project-automation bot moved this to ✏️ Draft in Pillarbox Mar 12, 2025
@github-actions
Copy link

github-actions bot commented Mar 12, 2025 •
edited
Loading

Code Coverage

Overall Project 51.38% -0.11% 🟢
Files changed 76.16% 🟢

Module Coverage
:pillarbox-player 57.26% -0.22% 🟢
Files
Module File Coverage
:pillarbox-player Monitoring.kt 88.29% -0.21% 🟢
EventMessageData.kt 78.1% 🟢
Session.kt 56.66% -3.94% 🟢
ErrorMessageData.kt 50.9% 🟢

@MGaetan89 MGaetan89 requested a review from StaehliJ March 12, 2025 13:52
@MGaetan89
Add application information and audio/subtitles language to monitorin…
982a9ea 
…g events

This commit refactors the monitoring events to include more information:
- Adds application id and version to `Session`.
- Adds `audio` and `subtitles` information to `EventMessageData` and `ErrorMessageData`.
- Removes unused `origin` field from `Session.Media`.
- Adds unit tests for the above.
@MGaetan89 MGaetan89 force-pushed the 926-add-track-and-application-information-to-monitoring-data branch from fe98ea1 to 982a9ea Compare March 13, 2025 08:33
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 17f5b08 Mar 13, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the 926-add-track-and-application-information-to-monitoring-data branch March 13, 2025 08:50
@github-project-automation github-project-automation bot moved this from ✏️ Draft to ✅ Done in Pillarbox Mar 13, 2025
@MGaetan89 MGaetan89 mentioned this pull request Apr 2, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add track and application information to monitoring data

2 participants

@MGaetan89 @StaehliJ