Skip to content

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Mar 12, 2025

Pull request

Description

This commit updates the pillarbox-demo-cast module to use androidx-mediarouter-compose instead of the current CastButton.

Changes made

  • Remove the custom CastButton from pillarbox-cast.
  • Remove Compose dependencies from pillarbox-cast.
  • Add PillarboxCastPlayer.isCastSessionAvailableAsFlow() to pillarbox-cast.
  • Add some tests to pillarbox-cast.
  • Use the MediaRouteButton from androidx-mediarouter-compose instead.
  • Move the Cast icon in the top-right corner so it does not overlap with the player controls.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Mar 12, 2025
@MGaetan89 MGaetan89 linked an issue Mar 12, 2025 that may be closed by this pull request
@github-project-automation github-project-automation bot moved this to ✏️ Draft in Pillarbox Mar 12, 2025
@github-actions
Copy link

Code Coverage

Overall Project 51.42% 🟢
Files changed 100% 🟢

Module Coverage
:pillarbox-cast 8.47% 🟢
Files
Module File Coverage
:pillarbox-cast CastExtensions.kt 87.76% 🟢

@MGaetan89 MGaetan89 requested a review from StaehliJ March 12, 2025 11:42
@StaehliJ StaehliJ added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 2111b74 Mar 13, 2025
10 checks passed
@StaehliJ StaehliJ deleted the 917-create-a-demo-showing-cast-integration branch March 13, 2025 08:23
@github-project-automation github-project-automation bot moved this from ✏️ Draft to ✅ Done in Pillarbox Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Create a demo showing Cast integration

2 participants