Skip to content

Refactoring PillarboxAnalyticsCollector #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 9 commits into from
Mar 13, 2025
Merged

Refactoring PillarboxAnalyticsCollector #925

StaehliJ merged 9 commits into from
Mar 13, 2025

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Mar 5, 2025

Pull request

Description

The goal of this PR is to simplify PillarboxExoPlayer by creating PlaybackSessionManager and MetricsCollector into PillarboxAnalyticsCollector.

Changes made

  • Expose Session.getDeviceId used by the monitoring.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Mar 5, 2025 that may be closed by this pull request
Renove Monitoring from Player and put it into an AnalyticsCollector #924
Closed
@github-project-automation github-project-automation bot moved this to ✏️ Draft in Pillarbox Mar 5, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 March 5, 2025 13:23
@github-actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

Code Coverage

Overall Project 50.94% -0.74% 🟢
Files changed 70.88% 🟢

Module Coverage
:pillarbox-player 57.17% -1.47% 🟢
Files
Module File Coverage
:pillarbox-player Context.kt 100% 🟢
PlaybackSessionManager.kt 92.86% -3.5% 🟢
Monitoring.kt 88.4% 🟢
PillarboxExoPlayer.kt 71.09% -4.67% 🟢
PillarboxAnalyticsCollector.kt 68.82% -1.18% 🟢
MetricsCollector.kt 68.2% -27.85% 🟢
Session.kt 57.64% 🟢

MGaetan89
MGaetan89 reviewed Mar 10, 2025
View reviewed changes
@StaehliJ StaehliJ force-pushed the refactoring-monitoring branch from 2707cec to b894b00 Compare March 12, 2025 10:16
@MGaetan89
Copy link
Contributor

MGaetan89 commented Mar 12, 2025

I just pushed some small changes in c914d67.
The rest looks good to me know 👍🏻

@MGaetan89 MGaetan89 removed a link to an issue Mar 12, 2025
Renove Monitoring from Player and put it into an AnalyticsCollector #924
Closed
@MGaetan89 MGaetan89 moved this from ✏️ Draft to 🍿 Code Review in Pillarbox Mar 12, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Mar 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 025bce2 Mar 13, 2025
10 checks passed
@StaehliJ StaehliJ deleted the refactoring-monitoring branch March 13, 2025 08:27
@github-project-automation github-project-automation bot moved this from 🍿 Code Review to ✅ Done in Pillarbox Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StaehliJ StaehliJ

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StaehliJ @MGaetan89