Skip to content

Conversation

@StaehliJ
Copy link
Contributor

Pull request

Description

  • Self-explanatory

Changes made

  • Add missing readme to module pillarbox-core-business-cast.
  • Update documentation for casts modules.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Feb 20, 2025 that may be closed by this pull request
1 task
@StaehliJ StaehliJ requested a review from MGaetan89 February 20, 2025 10:15
@github-actions
Copy link

github-actions bot commented Feb 20, 2025

Code Coverage

Overall Project 51.33% 🟢

There is no coverage information present for the Files changed

Copy link
Contributor

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions, but good overall

StaehliJ and others added 8 commits February 20, 2025 11:41
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
@StaehliJ StaehliJ enabled auto-merge February 20, 2025 10:44
@StaehliJ StaehliJ added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 39dbd92 Feb 20, 2025
8 checks passed
@StaehliJ StaehliJ deleted the 884-add-doc-for-googlecast-with-pillarbox branch February 20, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Add doc for GoogleCast with Pillarbox

2 participants