Skip to content

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Feb 12, 2025

Pull request

Description

Introduce same dsl pattern as it has been done with PillarboxExoPlayer that can configure each aspect of a PillarboxCastPlayer.

Samples

import ch.srgssr.pillarbox.cast.PillarboxCastPlayer

val castPlayer = PillarboxCastPlayer(context, Default) {
      mediaItemConverter(MyMediaItemConverter())
      seekBackIncrement(10.seconds)
      seekForwardIncrement(10.seconds)
      ....
}
import ch.srgssr.pillarbox.core.business.cast.PillarboxCastPlayer

val castPlayer = PillarboxCastPlayer(context) // SRG Configured.

Changes made

  • Add a SRG PillarboxCastPlayer builder that configure everything for SRG SSR content and Letterbox receiver.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Feb 12, 2025 that may be closed by this pull request
1 task
@github-actions
Copy link

github-actions bot commented Feb 12, 2025

Code Coverage

Overall Project 51.01% -0.62% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-core-business-cast 85.31% -3.27% 🟢
:pillarbox-cast 0% -17.25% 🟢
Files
Module File Coverage
:pillarbox-core-business-cast PillarboxSRG.kt 0% 🟢
:pillarbox-cast PillarboxCastPlayer.kt 0% -3.2% 🟢
DefaultCastTrackSelector.kt 0% 🟢
PillarboxCastPlayerBuilder.kt 0% 🟢

@StaehliJ StaehliJ marked this pull request as ready for review February 19, 2025 08:53
@StaehliJ StaehliJ force-pushed the 891-add-dsl-for-pillarboxcastplayer branch from fbfe0b3 to 77d4268 Compare February 21, 2025 08:47
@StaehliJ StaehliJ requested a review from MGaetan89 February 26, 2025 08:19
@MGaetan89 MGaetan89 force-pushed the 891-add-dsl-for-pillarboxcastplayer branch from 4254f74 to f814bf9 Compare March 4, 2025 13:00
@MGaetan89 MGaetan89 added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit d017deb Mar 4, 2025
10 checks passed
@MGaetan89 MGaetan89 deleted the 891-add-dsl-for-pillarboxcastplayer branch March 4, 2025 13:22
@github-project-automation github-project-automation bot moved this from ✏️ Draft to ✅ Done in Pillarbox Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Add DSL for PillarboxCastPlayer

2 participants