Skip to content

Don't crash when spritesheet can't be downloaded. #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 7 commits into from
Feb 19, 2025
Merged

Don't crash when spritesheet can't be downloaded. #893

StaehliJ merged 7 commits into from
Feb 19, 2025

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Feb 12, 2025

Pull request

Description

Fix a crash when spritesheet url can't be downloaded.

Changes made

  • When the sprite sheet url can't be downloaded the player behaves like it is done if the bitmap can't be decoded. If the sprite sheet track is selected nothing happens since there is no data.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Feb 12, 2025 that may be closed by this pull request
Don't crash if the sprite sheet can't be downloaded #892
Closed
@StaehliJ StaehliJ requested a review from MGaetan89 February 12, 2025 13:53
@github-actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

Code Coverage

Overall Project 51.23% -0.04% 🟢
Files changed 92.86% 🟢

Module Coverage
:pillarbox-core-business 81.84% -0.19% 🟢
Files
Module File Coverage
:pillarbox-core-business SpriteSheetLoader.kt 100% 🟢
SpriteSheetMediaSource.kt 96.88% 🟢
SRGAssetLoader.kt 90.76% 🟢
SRGAssetLoaderConfig.kt 80.14% -4.26% 🟢
SpriteSheetMediaPeriod.kt 48.87% -1.36% 🟢

MGaetan89
MGaetan89 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easy to add some tests here?

@StaehliJ StaehliJ requested a review from MGaetan89 February 19, 2025 08:11
@StaehliJ StaehliJ force-pushed the 892-dont-crash-if-the-sprite-sheet-cant-be-downloaded branch from 1eebff0 to f7b7a30 Compare February 19, 2025 14:03
@StaehliJ StaehliJ added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit e841349 Feb 19, 2025
8 checks passed
@StaehliJ StaehliJ deleted the 892-dont-crash-if-the-sprite-sheet-cant-be-downloaded branch February 19, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't crash if the sprite sheet can't be downloaded

2 participants

@StaehliJ @MGaetan89