Skip to content

871 provide a mediaitemconverter for pillarbox #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 24 commits into from
Feb 12, 2025
Merged

871 provide a mediaitemconverter for pillarbox #883

StaehliJ merged 24 commits into from
Feb 12, 2025

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Feb 4, 2025

Pull request

Description

The goal of this PR is to have MediaItemConverter that works with urls and SRG SSR content. It allow to send and receiver items to and from a SRGLetterbox cast receiver.

Changes made

  • Add new pillarbox-core-business-cast module that handle core business MediaItemConverter that can be use with SRG SSR google cast receivers.
  • Add an artwork image when casting in pillarbox-demo-cast.
  • Show how to implements a local to remote to local experience inside the pillarbox-demo-cast.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Feb 4, 2025 that may be closed by this pull request
Provide a MediaItemConverter for Pillarbox #871
Closed
@github-actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Code Coverage

Overall Project 51.16% -1.04% 🟢
Files changed 56.11% 🟢

Module Coverage
:pillarbox-core-business-cast 88.19% -11.81% 🟢
:pillarbox-player 57.41% -0.04% 🟢
:pillarbox-cast 0% -29.46% 🟢
Files
Module File Coverage
:pillarbox-core-business-cast SRGMediaItemConverter.kt 88.19% -11.81% 🟢
:pillarbox-player PillarboxMediaPeriod.kt 95.81% -4.19% 🟢
:pillarbox-cast CastExtensions.kt 0% -47.83% 🟢
PillarboxCastPlayer.kt 0% -3.96% 🟢
CastForwardingListener.kt 0% 🟢

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 5, 2025
View reviewed changes
@StaehliJ StaehliJ requested a review from MGaetan89 February 5, 2025 13:45
MGaetan89
MGaetan89 approved these changes Feb 6, 2025
View reviewed changes
@StaehliJ StaehliJ added this to the Cast milestone Feb 10, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
@StaehliJ StaehliJ requested a review from MGaetan89 February 11, 2025 08:42
@StaehliJ StaehliJ enabled auto-merge February 12, 2025 09:16
@StaehliJ StaehliJ added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 6faa4eb Feb 12, 2025
9 checks passed
@StaehliJ StaehliJ deleted the 871-provide-a-mediaitemconverter-for-pillarbox branch February 12, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

Cast

Development

Successfully merging this pull request may close these issues.

Provide a MediaItemConverter for Pillarbox

2 participants

@StaehliJ @MGaetan89