Skip to content

Conversation

@StaehliJ
Copy link
Contributor

Pull request

Description

Add tracks selection to PillarboxCastPlayer that can be customized with CastTrackSelector.
Pillarbox provides a default CastTrackSelector that handles only TrackSelectionOverride.
TrackSelectionParametersare not applied again when changing MediaItemas the truth is stored on the CastReceiver and shouldn't be store locally.

Changes made

  • PillarboxCastPlayer.setTrackSelectionParameters do modify cast track selection.
  • Tracks from Cast are parse correctly.
  • Add CastTrackSelectorwith a default implementation DefaultTrackSelector.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Jan 30, 2025 that may be closed by this pull request
@StaehliJ StaehliJ requested a review from MGaetan89 January 30, 2025 08:29
@github-actions
Copy link

github-actions bot commented Jan 31, 2025

Code Coverage

Overall Project 50.84% -1.6% 🟢
Files changed 0% 🟢

Module Coverage
:pillarbox-cast 0% -63.37% 🟢
Files
Module File Coverage
:pillarbox-cast PillarboxCastPlayer.kt 0% -74.96% 🟢
DefaultCastTrackSelector.kt 0% 🟢

@StaehliJ StaehliJ requested a review from MGaetan89 February 3, 2025 15:09
@StaehliJ StaehliJ added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@StaehliJ StaehliJ added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 5be871f Feb 4, 2025
9 checks passed
@StaehliJ StaehliJ deleted the 868-handle-text-and-audio-tracks-with-castplayer branch February 4, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Handle text and audio tracks with CastPlayer

2 participants