-
Notifications
You must be signed in to change notification settings - Fork 4
868 handle text and audio tracks with castplayer #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StaehliJ
merged 16 commits into
main
from
868-handle-text-and-audio-tracks-with-castplayer
Feb 4, 2025
Merged
868 handle text and audio tracks with castplayer #879
StaehliJ
merged 16 commits into
main
from
868-handle-text-and-audio-tracks-with-castplayer
Feb 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/subtitles buttons
MGaetan89
reviewed
Jan 31, 2025
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/DefaultCastTrackSelector.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/PillarboxCastPlayer.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/PillarboxCastPlayer.kt
Show resolved
Hide resolved
Code Coverage
Files
|
MGaetan89
reviewed
Feb 3, 2025
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/PillarboxCastPlayer.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/PillarboxCastPlayer.kt
Outdated
Show resolved
Hide resolved
pillarbox-cast/src/main/java/ch/srgssr/pillarbox/cast/PillarboxCastPlayer.kt
Outdated
Show resolved
Hide resolved
MGaetan89
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
Add tracks selection to
PillarboxCastPlayerthat can be customized withCastTrackSelector.Pillarbox provides a default
CastTrackSelectorthat handles onlyTrackSelectionOverride.TrackSelectionParametersare not applied again when changingMediaItemas the truth is stored on theCastReceiverand shouldn't be store locally.Changes made
PillarboxCastPlayer.setTrackSelectionParametersdo modify cast track selection.Tracksfrom Cast are parse correctly.CastTrackSelectorwith a default implementationDefaultTrackSelector.Checklist