Skip to content

824 enforce official supported integration hostname #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 16 commits into from
Dec 19, 2024
Merged

824 enforce official supported integration hostname #833

StaehliJ merged 16 commits into from
Dec 19, 2024

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Dec 16, 2024

Pull request

Description

The goal of this PR is to limit urls that can use SRGAssetLoader.

Changes made

  • SRGMediaItem can only use official host.
  • SRGAssetLoader can load Asset only from known Integration Layer urls.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Dec 16, 2024 that may be closed by this pull request
Enforce official supported integration hostname #824
Closed
1 task
@StaehliJ StaehliJ force-pushed the 824-enforce-official-supported-integration-hostname branch from 958c0f8 to 551e56b Compare December 16, 2024 15:44
@StaehliJ StaehliJ enabled auto-merge December 16, 2024 15:47
@github-actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Code Coverage

Overall Project 52.11% -0.03% 🟢
Files changed 97.78% 🟢

Module Coverage
:pillarbox-core-business 81.54% -0.14% 🟢
Files
Module File Coverage
:pillarbox-core-business IlHost.kt 100% 🟢
ImageScalingService.kt 100% 🟢
SRGMediaItem.kt 100% 🟢
IlUrl.kt 95.95% -4.05% 🟢
SRGAssetLoader.kt 90.68% 🟢

@StaehliJ StaehliJ added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit e26644b Dec 19, 2024
9 checks passed
@StaehliJ StaehliJ deleted the 824-enforce-official-supported-integration-hostname branch December 19, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enforce official supported integration hostname

2 participants

@StaehliJ @MGaetan89