Skip to content

Remove Ktor dependency #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 10 commits into from
Dec 16, 2024
Merged

Remove Ktor dependency #829

MGaetan89 merged 10 commits into from
Dec 16, 2024

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Dec 12, 2024

Pull request

Description

This PR removes the dependency on Ktor from Pillarbox.

Changes made

  • Remove Ktor dependency.
  • Create RequestSender to parse from/to JSON and send network requests.
  • Remove HttpResultException.
  • Remove PillarboxHttpClient.
  • Remove Ktor rule from Dependabot.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 linked an issue Dec 12, 2024 that may be closed by this pull request
Drop the Ktor dependency #823
Closed
@github-actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Code Coverage

Overall Project 48.91% -0.33% 🟢
Files changed 75.7% 🟢

Module Coverage
:pillarbox-core-business 81.04% -0.54% 🟢
:pillarbox-player 57.35% -0.44% 🟢
Kover Gradle Plugin XML report for :plugins 7.21% 🟢
Files
Module File Coverage
:pillarbox-core-business HttpMediaCompositionService.kt 100% 🟢
ImageScalingService.kt 100% 🟢
SRGErrorMessageProvider.kt 100% 🟢
AkamaiTokenDataSource.kt 100% 🟢
SRGAssetLoader.kt 90.02% -3.06% 🟢
SRGAssetLoaderConfig.kt 83.33% -9.85% 🟢
AkamaiTokenProvider.kt 70.53% -0.53% 🟢
:pillarbox-player HttpResultException.kt 100% 🟢
JsonSerializer.kt 100% 🟢
RequestSender.kt 91.16% -8.84% 🟢
PillarboxBuilder.kt 78.55% -2.77% 🟢
MonitoringMessageHandler.kt 4.02% -24.71% 🟢
Kover Gradle Plugin XML report for :plugins PillarboxAndroidLibraryPublishingPlugin.kt 0% 🟢

@MGaetan89 MGaetan89 added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 9b1ebb0 Dec 16, 2024
9 checks passed
@MGaetan89 MGaetan89 deleted the 823-drop-the-ktor-dependency branch December 16, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop the Ktor dependency

2 participants

@MGaetan89 @StaehliJ