Skip to content

822 remove toggleablebox #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 10 commits into from
Dec 16, 2024
Merged

822 remove toggleablebox #828

MGaetan89 merged 10 commits into from
Dec 16, 2024

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Dec 11, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to remove helpers that are so simple to do that we remove them from the Pillarbox and moved into the demo.

Changes made

  • Remove composable ToggleableBox.
  • Remove composable DelayedVisibility.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ linked an issue Dec 11, 2024 that may be closed by this pull request
Remove ToggleableBox #822
Closed
1 task
@github-actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Code Coverage

Overall Project 51.94% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ force-pushed the 822-remove-toggleablebox branch from b0c2099 to c411e47 Compare December 16, 2024 10:33
@MGaetan89 MGaetan89 added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 2ee6651 Dec 16, 2024
9 checks passed
@MGaetan89 MGaetan89 deleted the 822-remove-toggleablebox branch December 16, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove ToggleableBox

2 participants

@StaehliJ @MGaetan89