Skip to content

Improve accessibility in the demo app #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 3 commits into from
Dec 12, 2024
Merged

Improve accessibility in the demo app #820

MGaetan89 merged 3 commits into from
Dec 12, 2024

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Dec 5, 2024

Pull request

Description

Improve accessibility in the demo app itself. These are mostly navigation-related changes. The player will be handled separately.

Changes made

  • Add language information to DemoItems so TalkBack can use the proper voice when reading information.
  • Add collection info on lists.
  • Add some missing content descriptions.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 self-assigned this Dec 5, 2024
@MGaetan89 MGaetan89 linked an issue Dec 5, 2024 that may be closed by this pull request
Accessibility #803
Closed
1 task
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 5, 2024 •
edited
Loading

Code Coverage

Overall Project 48.58% 🟢

There is no coverage information present for the Files changed

@MGaetan89 MGaetan89 requested a review from StaehliJ December 5, 2024 08:20
StaehliJ
StaehliJ reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@StaehliJ StaehliJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little adjustement maybe, Shouldn't we not focus automatically the top when user choose an item in the bottom navigation bar ?

@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Dec 10, 2024

Some little adjustement maybe, Shouldn't we not focus automatically the top when user choose an item in the bottom navigation bar ?

I've checked in multiple Google apps, and the behavior is always the same: when we select a tab in the bottom navigation, the focus remains there.

@MGaetan89 MGaetan89 enabled auto-merge December 11, 2024 15:12
@MGaetan89 MGaetan89 disabled auto-merge December 11, 2024 16:03
@MGaetan89 MGaetan89 enabled auto-merge December 11, 2024 16:03
@MGaetan89 MGaetan89 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit e8f789f Dec 12, 2024
9 checks passed
@MGaetan89 MGaetan89 deleted the 803-accessibility branch December 12, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accessibility

2 participants

@MGaetan89 @StaehliJ