Skip to content

Update to AndroidX Media3 1.5.0 #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 6 commits into from
Nov 27, 2024
Merged

Update to AndroidX Media3 1.5.0 #794

MGaetan89 merged 6 commits into from
Nov 27, 2024

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Nov 18, 2024 •
edited
Loading

Pull request

Description

Update the AndroidX Media3 dependency to 1.5.0.
The release notes are available here.

Changes made

  • Update to AndroidX Media3 1.5.0 and Guava to 33.3.1.
  • Update usages of the removed DefaultPreloadManager.Status.STAGE_LOADED_TO_POSITION_MS constant in favor of DefaultPreloadManager.Status.STAGE_LOADED_FOR_DURATION_MS.
  • Update PillarboxLoadControl to override the new onTracksSelected() and shouldContinuePreloading methods.
  • Update PillarboxPreloadManager to use DefaultPreloadManager.Builder instead of the deprecated DefaultPreloadManager constructor.
  • Add support for C.ROLE_FLAG_AUXILIARY in Format.roleString()
  • Update PillarboxMediaController to remove removed methods.
  • Disable Guava updates through Dependabot. Guava is updated at the same time as AndroidX Media3.

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@MGaetan89 MGaetan89 added the dependencies Pull requests that update a dependency file label Nov 18, 2024
@MGaetan89 MGaetan89 self-assigned this Nov 18, 2024
@github-actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Code Coverage

Overall Project 48.67% -0.17% 🟢
Files changed 63.95% 🟢

Module Coverage
:pillarbox-core-business 81.29% -0.03% 🟢
:pillarbox-player 56.6% -0.32% 🟢
Files
Module File Coverage
:pillarbox-core-business CommandersActStreaming.kt 96.04% -0.29% 🟢
:pillarbox-player Format.kt 100% 🟢
PillarboxPreloadManager.kt 85.88% -7.34% 🟢
PillarboxBuilder.kt 78.55% -1.04% 🟢
PillarboxLoadControl.kt 78.38% -6.49% 🟢
PreloadConfiguration.kt 0% 🟢
PillarboxMediaController.kt 0% -0.66% 🟢

@MGaetan89 MGaetan89 force-pushed the androidx_media3_1.5.0 branch 4 times, most recently from e8bd7f9 to eda06c6 Compare November 20, 2024 13:34
@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Nov 20, 2024

Moved to the backlog until the next release of AndroidX Media3 1.5.0

@MGaetan89 MGaetan89 mentioned this pull request Nov 25, 2024
Closed
@MGaetan89 MGaetan89 force-pushed the androidx_media3_1.5.0 branch from eda06c6 to 362e09a Compare November 25, 2024 20:24
@MGaetan89 MGaetan89 marked this pull request as ready for review November 26, 2024 06:07
@MGaetan89 MGaetan89 requested a review from StaehliJ November 26, 2024 06:07
@MGaetan89 MGaetan89 force-pushed the androidx_media3_1.5.0 branch from 362e09a to ff49dad Compare November 26, 2024 08:03
@StaehliJ StaehliJ linked an issue Nov 26, 2024 that may be closed by this pull request
Update to AndroidX Media3 1.5.0 #808
Closed
2 tasks
@StaehliJ StaehliJ force-pushed the androidx_media3_1.5.0 branch from a81e0e9 to 1f2df47 Compare November 26, 2024 13:14
MGaetan89
MGaetan89 commented Nov 26, 2024
View reviewed changes
Copy link
Contributor Author

@MGaetan89 MGaetan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@StaehliJ I've just moved the PreloadConfiguration to the root package, so it's in the same location as the other similar functions (PillarboxBandwidthMeter, PillarboxRenderersFactory, ...).

@MGaetan89 MGaetan89 added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 0a658dc Nov 27, 2024
9 checks passed
@MGaetan89 MGaetan89 deleted the androidx_media3_1.5.0 branch November 27, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

@MGaetan89 MGaetan89

Labels

dependencies Pull requests that update a dependency file

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to AndroidX Media3 1.5.0

2 participants

@MGaetan89 @StaehliJ