Update to AndroidX Navigation 2.8.0 #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

MGaetan89 merged 1 commit into main from update_navigation

Sep 16, 2024

Contributor

MGaetan89 commented Sep 13, 2024 •

edited

Loading

Pull request

Description

This PR updates to AndroidX Navigation 2.8.0. The changelog is available here.

Changes made

Update to AndroidX Navigation 2.8.0.
Migrate NavHost to use type-safe navigation.

Hopefully, future versions of AndroidX Navigation will simplify things a bit:

Support property level @Serializable (see b/348468840): with that we should be able to remove the buName workaround in ContentList.
Support compsable(KClass) (in addition to composable<Route>) (see b/361863272): this should allow us to remove the addContentListRoute function in both ListsHome files (in pillarbox-demo and pillarbox-demo-tv).

Checklist

Your branch has been rebased onto the main branch.
APIs have been properly documented (if relevant).
The documentation has been updated (if relevant).
New unit tests have been written (if relevant).
The demo has been updated (if relevant).
All pull request status checks pass.

MGaetan89 added the dependencies label

MGaetan89 requested a review from StaehliJ

September 13, 2024 11:16

MGaetan89 self-assigned this

github-actions bot commented Sep 13, 2024 •

edited

Loading

Code Coverage

Overall Project	50.1%	🟢

There is no coverage information present for the Files changed

StaehliJ reviewed

View reviewed changes

Contributor

StaehliJ left a comment

Sounds goods but still on the TV, when selecting an item in the player settings, it closed immediatly.

Contributor Author

MGaetan89 commented Sep 16, 2024

Sounds goods but still on the TV, when selecting an item in the player settings, it closed immediatly.

Yes, I've opened a dedicated ticket for that: #702

StaehliJ approved these changes

View reviewed changes

StaehliJ added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks


          Update to AndroidX Navigation 2.8.0

49bf420

MGaetan89 force-pushed the update_navigation branch from 5db065f to 49bf420 Compare

September 16, 2024 11:59

MGaetan89 added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

MGaetan89 added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

MGaetan89 added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

MGaetan89 added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

MGaetan89 added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

MGaetan89 added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

MGaetan89 added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

MGaetan89 added this pull request to the merge queue

Merged via the queue into main with commit 8199adc

MGaetan89 deleted the update_navigation branch

September 16, 2024 13:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels