Skip to content

Move Chapters and Credits into MediaMetadata #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 4 commits into from
Aug 27, 2024
Merged

Move Chapters and Credits into MediaMetadata #687

MGaetan89 merged 4 commits into from
Aug 27, 2024

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Aug 27, 2024 •
edited
Loading

Pull request

Description

The goal of this PR is to move Pillarbox metadata to the actual MediaMetadata of Media3. BlockedTimeRange has not been changed has it is more like a feature than actual metadata.

Changes made

  • Asset has been simplified to reflet changes.
  • To add Chapters to Pillarbox MediaMetadata.Builder.setChapters has been added.
  • To add Credits to Pillarbox MediaMetadata.Builder.setCredits has been added.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Aug 27, 2024 that may be closed by this pull request
Deliver Pillarbox metadata inside MediaMetadata #684
Closed
1 task
@github-actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

Code Coverage

Overall Project 48.47% -0.13% 🟢
Files changed 87.11% 🟢

Module Coverage
:pillarbox-core-business 82.55% -0.13% 🟢
:pillarbox-player 51.14% -0.22% 🟢
Files
Module File Coverage
:pillarbox-core-business DefaultMediaMetaDataProvider.kt 94.33% -4.96% 🟢
SRGAssetLoader.kt 86.12% 🟢
:pillarbox-player PillarboxData.kt 100% 🟢
Asset.kt 100% 🟢
MediaMetadata.kt 98.41% -1.59% 🟢
TimeRangeTracker.kt 94.85% -1.24% 🟢
PillarboxMediaSource.kt 92.28% 🟢
Player.kt 31.96% -7.22% 🟢

MGaetan89
MGaetan89 approved these changes Aug 27, 2024
View reviewed changes
@MGaetan89 MGaetan89 added this pull request to the merge queue Aug 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit c0ad602 Aug 27, 2024
@MGaetan89 MGaetan89 deleted the 684-deliver-pillarbox-metadata-inside-mediametadata branch August 27, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deliver Pillarbox metadata inside MediaMetadata

2 participants

@StaehliJ @MGaetan89