Skip to content

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Aug 12, 2024

Pull request

Description

When sliding on a PillarboxSlider outside of its bounds, the display value may be negative, or bigger than the media duration.
This PR changes that by making sure that the gesture horizontal offset is in [0, sliderWidth].

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 added the bug Something isn't working label Aug 12, 2024
@MGaetan89 MGaetan89 added this to the Demo milestone Aug 12, 2024
@MGaetan89 MGaetan89 self-assigned this Aug 12, 2024
@github-actions
Copy link

Code Coverage

Overall Project 48.96% 🟢

There is no coverage information present for the Files changed

@StaehliJ StaehliJ added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit d568c0b Aug 12, 2024
@MGaetan89 MGaetan89 deleted the fix_PillarboxSlider branch August 12, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants