Skip to content

Add argument to set Player.getMaxSeekToPreviousPosition when creating a PillarboxExoPlayer #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 1 commit into from
Jul 30, 2024
Merged

Add argument to set Player.getMaxSeekToPreviousPosition when creating a PillarboxExoPlayer #659

MGaetan89 merged 1 commit into from
Jul 30, 2024

Conversation

@MGaetan89
Copy link
Contributor

@MGaetan89 MGaetan89 commented Jul 29, 2024 •
edited
Loading

Pull request

Description

This PR adds a new maxSeekToPreviousPosition argument to the constructors of PillarboxExoPlayer and DefaultPillarbox, allowing the integrator to configure the delay until which seeking back goes to the beginning of the media.

Changes made

  • Self-explanatory.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@MGaetan89 MGaetan89 linked an issue Jul 29, 2024 that may be closed by this pull request
GetMaxDuration #558
Closed
2 tasks
@github-actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

Code Coverage

Overall Project 48.96% -0.02% 🟢
Files changed 87.8% 🟢

Module Coverage
:pillarbox-core-business 82.54% -0.07% 🟢
:pillarbox-player 50.85% -0.01% 🟢
Files
Module File Coverage
:pillarbox-core-business DefaultPillarbox.kt 50.88% -3.51% 🟢
:pillarbox-player PillarboxExoPlayer.kt 84.25% -0.11% 🟢

@StaehliJ StaehliJ force-pushed the 558-getmaxduration branch from 1d1563c to d635240 Compare July 30, 2024 07:19
@StaehliJ
Copy link
Contributor

StaehliJ commented Jul 30, 2024

When we merge the demo settings we could maybe add this into the settings.

@StaehliJ StaehliJ force-pushed the 558-getmaxduration branch from d635240 to 48fd019 Compare July 30, 2024 07:41
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit 8e65327 Jul 30, 2024
@MGaetan89 MGaetan89 deleted the 558-getmaxduration branch July 30, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GetMaxDuration

2 participants

@MGaetan89 @StaehliJ