Skip to content

Bump robolectric from 4.12.2 to 4.13 #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 3 commits into from
Jul 11, 2024
Merged

Bump robolectric from 4.12.2 to 4.13 #630

MGaetan89 merged 3 commits into from
Jul 11, 2024

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 8, 2024

Bumps robolectric from 4.12.2 to 4.13.
Updates org.robolectric:robolectric from 4.12.2 to 4.13

Release notes

Sourced from org.robolectric:robolectric's releases.

Robolectric 4.13 is a large collection of improvements. Some major improvements include:

  • Better support for HW rendering in Robolectric Native Graphics (RNG)
    • HW rendering is now supported all the way down to Android P.
    • Increased compatibility with Compose's graphics layer.

Note while some of these PRs below are related to Android V support, Android V is currently not supported in Robolectric 4.13. As soon as it is supported, we will make a 4.14 release.

What's Changed

... (truncated)

Commits
  • 79bc303 Bump version to 4.13.
  • 7083bb4 Remove empty shadows:versioning from settings.gradle
  • 052dd04 Disable deployed for integration_testing/versioning
  • 91f38c3 Bump the androidx-test group with 9 updates
  • ae33a5b Regenerate resources
  • 0461254 ci: Exclude Manifest.java and R.java from google-java-format
  • 202a6ac Remove Multidex from integration_tests/androidx_test and `integration_tests...
  • 6e1f1b5 Merge branch 'master' into 'google'
  • 559c84c Enable native PixelCopy for Android P
  • 67a85b0 Run ImageReader.imageReader_setOnImageAvailableListener on Android P+
  • Additional commits viewable in compare view

Updates org.robolectric:annotations from 4.12.2 to 4.13

Release notes

Sourced from org.robolectric:annotations's releases.

Robolectric 4.13 is a large collection of improvements. Some major improvements include:

  • Better support for HW rendering in Robolectric Native Graphics (RNG)
    • HW rendering is now supported all the way down to Android P.
    • Increased compatibility with Compose's graphics layer.

Note while some of these PRs below are related to Android V support, Android V is currently not supported in Robolectric 4.13. As soon as it is supported, we will make a 4.14 release.

What's Changed

... (truncated)

Commits
  • 79bc303 Bump version to 4.13.
  • 7083bb4 Remove empty shadows:versioning from settings.gradle
  • 052dd04 Disable deployed for integration_testing/versioning
  • 91f38c3 Bump the androidx-test group with 9 updates
  • ae33a5b Regenerate resources
  • 0461254 ci: Exclude Manifest.java and R.java from google-java-format
  • 202a6ac Remove Multidex from integration_tests/androidx_test and `integration_tests...
  • 6e1f1b5 Merge branch 'master' into 'google'
  • 559c84c Enable native PixelCopy for Android P
  • 67a85b0 Run ImageReader.imageReader_setOnImageAvailableListener on Android P+
  • Additional commits viewable in compare view

Updates org.robolectric:shadows-framework from 4.12.2 to 4.13

Release notes

Sourced from org.robolectric:shadows-framework's releases.

Robolectric 4.13 is a large collection of improvements. Some major improvements include:

  • Better support for HW rendering in Robolectric Native Graphics (RNG)
    • HW rendering is now supported all the way down to Android P.
    • Increased compatibility with Compose's graphics layer.

Note while some of these PRs below are related to Android V support, Android V is currently not supported in Robolectric 4.13. As soon as it is supported, we will make a 4.14 release.

What's Changed

... (truncated)

Commits
  • 79bc303 Bump version to 4.13.
  • 7083bb4 Remove empty shadows:versioning from settings.gradle
  • 052dd04 Disable deployed for integration_testing/versioning
  • 91f38c3 Bump the androidx-test group with 9 updates
  • ae33a5b Regenerate resources
  • 0461254 ci: Exclude Manifest.java and R.java from google-java-format
  • 202a6ac Remove Multidex from integration_tests/androidx_test and `integration_tests...
  • 6e1f1b5 Merge branch 'master' into 'google'
  • 559c84c Enable native PixelCopy for Android P
  • 67a85b0 Run ImageReader.imageReader_setOnImageAvailableListener on Android P+
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 8, 2024
@MGaetan89
Copy link
Contributor

MGaetan89 commented Jul 9, 2024 •
edited
Loading

The new Dependency Analysis Plugin warning is:

Advice for :pillarbox-player
Unused dependencies which should be removed:
  androidTestImplementation(libs.androidx.test.monitor)

But we use that dependency here:

pillarbox-android/pillarbox-player/src/androidTest/java/ch/srgssr/pillarbox/player/IsPlayingAllTypeOfContentTest.kt

Line 12 in 36803b9

import androidx.test.platform.app.InstrumentationRegistry.getInstrumentation

So we can't remove it (even if the test still seems to pass without it, Android Studio displays an error because it can not find the class).
I'll ignore this warning for now.

I'll have a look at the failing tests too.

@github-actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

Code Coverage

Overall Project 48.99% 🟢

There is no coverage information present for the Files changed

@MGaetan89
Copy link
Contributor

MGaetan89 commented Jul 9, 2024

It looks like these failures were mainly due to the fact that our AndroidX Test dependencies were outdated.
I've updated them to the latest version, and it seems to work fine now.

Here are the corresponding changes:

@StaehliJ adding you for a second review.

@MGaetan89 MGaetan89 requested a review from StaehliJ July 9, 2024 07:08
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 11, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 11, 2024
@MGaetan89
Copy link
Contributor

MGaetan89 commented Jul 11, 2024

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 11, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

dependabot bot and others added 3 commits July 11, 2024 14:17
@dependabot @MGaetan89
Bump robolectric from 4.12.2 to 4.13
fd81fdf 
Bumps `robolectric` from 4.12.2 to 4.13.

Updates `org.robolectric:robolectric` from 4.12.2 to 4.13
- [Release notes](https://github.com/robolectric/robolectric/releases)
- [Commits](robolectric/robolectric@robolectric-4.12.2...robolectric-4.13)

Updates `org.robolectric:annotations` from 4.12.2 to 4.13
- [Release notes](https://github.com/robolectric/robolectric/releases)
- [Commits](robolectric/robolectric@robolectric-4.12.2...robolectric-4.13)

Updates `org.robolectric:shadows-framework` from 4.12.2 to 4.13
- [Release notes](https://github.com/robolectric/robolectric/releases)
- [Commits](robolectric/robolectric@robolectric-4.12.2...robolectric-4.13)

---
updated-dependencies:
- dependency-name: org.robolectric:robolectric
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.robolectric:annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.robolectric:shadows-framework
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@MGaetan89
Update AndroidX Test dependencies
1221648
@MGaetan89
Address Dependency Analysis Plugin warning
1d2079c
@MGaetan89 MGaetan89 force-pushed the dependabot/gradle/robolectric-4.13 branch from 079cf91 to 1d2079c Compare July 11, 2024 12:17
@MGaetan89 MGaetan89 added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 0f567d8 Jul 11, 2024
@MGaetan89 MGaetan89 deleted the dependabot/gradle/robolectric-4.13 branch July 11, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StaehliJ StaehliJ StaehliJ approved these changes

+1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

Pillarbox
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MGaetan89 @StaehliJ