Skip to content

PLAY-6636 CommandersAct media event send media_audiodescription_on #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaehliJ merged 2 commits into from
Jul 4, 2024
Merged

PLAY-6636 CommandersAct media event send media_audiodescription_on #629

StaehliJ merged 2 commits into from
Jul 4, 2024

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Jul 3, 2024

Pull request

Description

The goal of this PR is to add media_audiodescription_on with CommandersAct media event when the current audio track has audio description.

Changes made

  • Self-explanatory

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ linked an issue Jul 3, 2024 that may be closed by this pull request
Audio Description flag in analytics #624
Closed
2 tasks
@github-actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Code Coverage

Overall Project 49.03% -0.01% 🟢
Files changed 96.77% 🟢

Module Coverage
:pillarbox-analytics 88.54% 🟢
:pillarbox-core-business 82.74% -0.04% 🟢
Files
Module File Coverage
:pillarbox-analytics TCMediaEvent.kt 100% 🟢
:pillarbox-core-business CommandersActStreaming.kt 96.04% -0.29% 🟢

@StaehliJ StaehliJ requested a review from MGaetan89 July 4, 2024 06:38
@StaehliJ StaehliJ enabled auto-merge July 4, 2024 07:21
@StaehliJ StaehliJ added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 36803b9 Jul 4, 2024
@StaehliJ StaehliJ deleted the 624-audio-description-flag-in-analytics branch July 4, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Pillarbox
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Audio Description flag in analytics

2 participants

@StaehliJ @MGaetan89