Skip to content

Fixes #13750: GDPR modal not in foreground.#13823

Merged
KarnaiahPesula merged 2 commits intodevelopmentfrom
bug/13750-gdpr-modal
Feb 2, 2026
Merged

Fixes #13750: GDPR modal not in foreground.#13823
KarnaiahPesula merged 2 commits intodevelopmentfrom
bug/13750-gdpr-modal

Conversation

@Pa-Touche
Copy link
Copy Markdown
Contributor

@Pa-Touche Pa-Touche commented Feb 2, 2026 •
edited by coderabbitai bot
Loading

Fixes #13750

Summary by CodeRabbit

  • Bug Fixes
    • GDPR-related popup windows now display reliably in front of other modal windows and dialogs, preventing visibility and stacking issues.
    • Improved focus handling for GDPR dialog windows so they receive focus at the correct time for smoother interactions.
    • Consistent foreground rendering for GDPR popups across different flows, reducing cases where the dialog could be obscured.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 2, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Adds a front-element style and a VaadinUiUtil helper to create foreground popup windows; replaces GDPR popup creation calls to use the new helper and adjusts when the GDPR window receives focus so it is shown and focused after being added to the UI.

Changes

Cohort / File(s) Summary
UI utility
sormas-ui/src/main/java/de/symeda/sormas/ui/utils/VaadinUiUtil.java		 Added FRONT_ELEMENT_STYLE_NAME constant and createForegroundPopupWindow() public API; replaced GDPR popup callsites to use the new method; moved focus() call to after window is added to the UI.
Styling
sormas-ui/src/main/webapp/VAADIN/themes/sormas/global.scss		 Added .front-element rule with z-index: 99999 !important inside sormas-global to force popups to render above other elements.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I dug a tunnel to the front so sly,
A little popup now hops up high.
GDPR blooms in clear view bright,
No more hiding — all is right! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the issue being fixed (#13750) and the specific problem (GDPR modal not in foreground), accurately summarizing the main change.
Description check ✅ Passed The pull request description references the issue number (#13750) as required by the template, meeting the minimal template requirements.
Linked Issues check ✅ Passed The code changes directly address issue #13750 by implementing z-index layering and foreground popup methods to ensure GDPR modals display in front of other activities.
Out of Scope Changes check ✅ Passed All changes are focused on fixing the GDPR modal layering issue: new styling for foreground elements, a foreground popup creation method, and adjustments to GDPR window handling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bug/13750-gdpr-modal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Pa-Touche Pa-Touche changed the title FIX: 13750: BUG: GDPR modal not in foreground. Fixes #13750: GDPR modal not in foreground. Feb 2, 2026
@sormas-vitagroup
Copy link
Copy Markdown
Contributor

sormas-vitagroup commented Feb 2, 2026

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13823

1 similar comment
@sormas-vitagroup
Copy link
Copy Markdown
Contributor

sormas-vitagroup commented Feb 2, 2026

SonarCloud analysis: https://sonarcloud.io/dashboard?id=SORMAS-Project&pullRequest=13823

@KarnaiahPesula KarnaiahPesula merged commit 95ad045 into development Feb 2, 2026
8 of 10 checks passed
@KarnaiahPesula KarnaiahPesula deleted the bug/13750-gdpr-modal branch February 2, 2026 14:18
@Pa-Touche Pa-Touche self-assigned this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KarnaiahPesula KarnaiahPesula KarnaiahPesula approved these changes

Assignees

@Pa-Touche Pa-Touche

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GDPR warning text showing up behind activity box making it not readable until activity is complete

3 participants

@Pa-Touche @sormas-vitagroup @KarnaiahPesula