[Celestica]: Add support for Blackstone platform#262
Merged
mudsut4ke merged 34 commits intoSONIC-DEV:202012_Blackstonefrom Dec 14, 2021
Merged
[Celestica]: Add support for Blackstone platform#262mudsut4ke merged 34 commits intoSONIC-DEV:202012_Blackstonefrom
mudsut4ke merged 34 commits intoSONIC-DEV:202012_Blackstonefrom
Conversation
…ytest (sonic-net#7431) Co-authored-by: Shi Lei <shil@centecnetworks.com>
…v-switch-driver [device/celestica-blackstone]: Update switch CPLD driver follow FPGA i2c buses
This reverts commit c133492.
This reverts commit 318b145.
device/celestica/x86_64-cel_blackstone-r0/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
device/celestica/x86_64-cel_blackstone-r0/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
device/celestica/x86_64-cel_blackstone-r0/sonic_platform/chassis.py
Outdated
Show resolved
Hide resolved
added 2 commits
October 27, 2021 15:07
* [platform/cel-blackstone]: update misc_cpld device name * [platform/cel-blackstone]: update misc_cpld driver version * [platform/cel-blackstone]: update misc_cpld init command
* [platform/cel-blackstone]: update FPGA driver to support BMC I2C * [platform/cel-blackstone]: update i2c devices driver init command
pphuchar
reviewed
Oct 27, 2021
Collaborator
pphuchar
left a comment
There was a problem hiding this comment.
As commented.
If possible, please apply Linux kernel codes style to the source files under blackstone/modules/ path.
| static void fpga_pci_remove(void) | ||
| { | ||
| iounmap(fpga_dev.data_base_addr); | ||
| // class_unregister(fpgafwclass); |
Collaborator
There was a problem hiding this comment.
Can this unused codes be removed?
|
|
||
| if (dev){ | ||
| err = fpga_pci_probe(dev); | ||
| // pci_dev_put(dev); |
| @@ -0,0 +1,846 @@ | |||
| // SPDX-License-Identifier: GPL-2.0 | |||
Collaborator
There was a problem hiding this comment.
Since we using the ocores-i2c from the kernel source tree, could this module and the i2c-ocores.h be removed from the platform-specific path?
added 2 commits
November 5, 2021 15:22
* [device/celestica-blackstone]: update necessary chassis apis * [platform/cel-blackstone]: add platform api installer * [platform/cel]: update missing apis installer command * [device/celestica-blackstone]: update sfputil follow hw spec * [device/celestica-blackstone]: update skip_syseepromd config for pmon
* [device/celestica-blackstone]: update necessary chassis apis * [platform/cel-blackstone]: add platform api installer * [platform/cel]: update missing apis installer command * [device/celestica-blackstone]: update sfputil follow hw spec * [device/celestica-blackstone]: update skip_syseepromd config for pmon * [platform/cel]: update api installer script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Note