Added regexp support for response codes #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice! Can you please add a test? |
orgads
requested changes
Nov 7, 2024
Contributor
|
The second commit message mentions style fixes and DTD update, but looks like you forgot to stage them? |
Contributor
|
Great, just fix the test author name and squash the commits and we're good to go. |
Now the regexp_match attribute should also work for response codes. Example: <recv response="^18" regexp_match="true" optional="true">
Author
|
Commits squashed. Hopefully all is OK, this is my first attempt to contribute to a project on GH, so it takes some googling and learning. |
orgads
approved these changes
Nov 7, 2024
Contributor
|
You lost the merged changes on squash. I fixed it for you. |
Contributor
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the regexp_match attribute should also work for response codes. Example:
<recv response="^18" regexp_match="true" optional="true">