Few additions to the code #569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add define to use local ip hints When USE_LOCAL_IP_HINTS is defined, prioritize local interface hints and use them when deciding the remote address. Useful when remote is a FQDN which can resolve to both IPv4 nd IPv6. 2. Generate random SSRC 3. Return ok if xml scenario finished ok. Log rtp or echo errors 4. Make TLS client cert/key file optional
Member
|
Looks sane. Could you split those up into separate PRs? Thanks! |
Contributor
Author
|
Hi, yes will try splitting them in separate PRs. |
Contributor
Author
|
Closing this PR as is, and will open new PRs for each task, and reference back this PR. |
This was referenced Dec 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, we are using SIPp with the following features and I wonder if they are of interest for the upstream community:
When USE_LOCAL_IP_HINTS is defined, prioritize local interface hints and
use them when deciding the remote address.
Useful when remote is a FQDN which can resolve to both IPv4 nd IPv6.
Generate random SSRC
Return ok if xml scenario finished ok. Log rtp or echo errors
Make TLS client cert/key file optional
Thank you,
Stefan