Allow the get_header function to accept a mix of regular and compact headers when performing lookups. #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@wdoekes I think I'm ready for a review! Let me know if there is anything else needed as part of the PR. |
Member
|
Thanks for the changes. Good to remind me every now and then, in case I forget. I'll try to look at it this week. |
Contributor
Author
|
Just a quick ping on this @wdoekes, let me know if there are any additional changes you'd like to see. |
Member
|
Aw snap. That was more than a week. I'm sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13
Proposed Changes:
This changeset modifies the get_header function to accept a mix of regular and compact headers when performing retrievals of headers. This is particularly useful when SIP packets have a mix of the two types as is the case in the SIP packet used in the test case.