Merged
Conversation
added 19 commits
January 1, 2020 22:42
…Window and Slepian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
SHGrid.plot()routine by adding a number of optional arguments along with support for projections usingCartopyandpygmt.SHGrid.SHGrid.plot(projection=ccrs.ProjectionName()).cb_labelfor labels,cb_ylabelfor a label on the y axis of the colorbar,cb_tick_intervalfor specifying the major tick interval,cb_minor_tick_intervalfor specifying minor tick intervals,cb_trianglesfor plotting upper/lower limit triangles at the ends of the colorbar, andcb_offsetto override the default spacing between the map and colorbar.cmap_limitsto specify the lower and upper bounds of the data, as well as an interval for constant color intervals, andcmap_reverseto reverse the colormap.ticksspecifies which ticks and annotations to show, using a syntax from gmt (i.e.,'WSen').plotgmt. This function takes nearly the same arguments asplot(). As soon as pygmt implements projection classes (Implement Projection classes to encapsulate arguments GenericMappingTools/pygmt#379), this will be incorporated into theplotfunction in the same manner as cartopy was.plot()function.Other changes:
SHGrid.to_real()andSHGrid.to_imag()return the real and imaginary components of a complexSHGridinstance.copytoSHCoeffs.pad().