Skip to content

Conversation

@G-071
Copy link
Member

@G-071 G-071 commented Oct 26, 2020

Some package managers (nix) expect scons projects to use the lower-case prefix parameter. This commit adds such a prefix parameter. To avoid breaking any existing scripts/installations/... the previous PREFIX parameter takes precedence over the lower-case prefix parameter. Unless you are dealing with a tool that expects a lower-case prefix, I would recommend to continue to use PREFIX. This PR just adds the alternative if required!

Some package managers (nix) expect scons projects to use the lower-case
prefix parameter. This makes commit makes SGpp compatible with those
package managers.
@G-071 G-071 requested a review from leiterrl October 26, 2020 21:27
@leiterrl
Copy link
Member

I would suggest to also throw an error if both lower- and uper-case prefixes are defined.

@leiterrl leiterrl merged commit 0443a21 into master Nov 2, 2020
@leiterrl leiterrl deleted the different_prefix_parameter branch November 2, 2020 08:20
@leiterrl leiterrl added this to the v3.4.0 milestone Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants