Preserve header blocks when using clang-format #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default option of the google style is to regroup the headers with no regards to any blocks. This is incompatible with our style checking later in the build process!
freifrauvonbleifrei
approved these changes
Jun 4, 2020
Contributor
freifrauvonbleifrei
left a comment
There was a problem hiding this comment.
neat little change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default option of the google style is to regroup the headers with no
regards to any blocks. This is incompatible with our style checking
later in the build process!
This PR fixes this issue by setting the appropriate clang-format option.