Truncated combi #197
Merged
Truncated combi #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 21, 2019 13:54
valentjn
reviewed
Dec 15, 2019
Member
valentjn
left a comment
There was a problem hiding this comment.
- Test for
fromRegularSparseTruncatedmissing. l_min->truncationLevelwould be more consistent with the existing variables.- The meaning of
nseems to deviate from the literature, where it's the level sum of the highest diagonal (in the code, it's the distance of the highest diagonal to the truncation level). If this is intended, this should be reflected in the documentation. If not,nhas to be shifted. - @freifrauvonbleifrei I can't review my own code, you have to do this (or you already did).
Member
|
@freifrauvonbleifrei Not sure "where the ball currently lies" 😉 Is this PR still current? Am I as reviewer supposed to do something? Is this worked on during the next two days' Coding Days? |
MichaelReh
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request contains two features: a linear dehierarchization by @valentjn and a generator for a truncated regular combination, where a minimum resolution vector lmin can be set.