Redesigned combigrid module #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tagging @MichaelReh and @freifrauvonbleifrei as main users/CT experts. |
Member
Author
|
Apart from some suggestions, I didn't hear any fundamental objections in the discussion last Thursday. Will this be merged then? Otherwise I fear that this PR dies when I'm leaving the group. Missing features can be implemented by students. |
Member
Author
|
I would really appreciate if we could merge this. Pretty sure it will soon get worse than the 83 commits it's already behind |
MichaelReh
previously approved these changes
Nov 18, 2019
Otherwise this clashes with OperationEval::eval( const DataMatrix& alpha, const DataVector& point, DataVector& value) as both DataVector and DataMatrix are std::vector<double>s.
7da7955 to
d16f984
Compare
MichaelReh
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combigrid module currently has some usability issues, see #141. This is a proposal for a redesigned combigrid module with improved usability. Since it's written from scratch, a lot of features of the old module are currently missing in this draft.
Current TODO list:
Closes #141.