Skip to content

Add support for SwiftUI Element Tab#146

Merged
StevenSorial merged 6 commits intoSFSafeSymbols:stablefrom
timbms:addTab
Oct 4, 2025
Merged

Add support for SwiftUI Element Tab#146
StevenSorial merged 6 commits intoSFSafeSymbols:stablefrom
timbms:addTab

Conversation

@timbms
Copy link
Contributor

@timbms timbms commented Sep 20, 2025

  • Starting point for adding SwiftUI Tab

Signed-off-by: Tim Müller-Seydlitz <timbms@gmail.com>
Signed-off-by: Tim Müller-Seydlitz <timbms@gmail.com>
@timbms timbms changed the title addTab Add support for SwiftUI Element Tab Sep 20, 2025
@StevenSorial
Copy link
Member

@timbms Thanks for the effort. Tab has 18 initializers for SF Symbols, it's confusing on the web because you have to select "Show all declarations". Please also take a look at this comment for more info

timbms and others added 2 commits September 26, 2025 09:42
Signed-off-by: Tim Müller-Seydlitz <timbms@gmail.com>
@timbms
Copy link
Contributor Author

timbms commented Sep 26, 2025

I now covered all relevant Tab initializers. I followed the order Apple used in the SwiftUI definition.
@StevenSorial It would be great if you could unblock the CI. I have no clue what need to be done. In general, wouldn't it be cool to make a new release?

@StevenSorial
Copy link
Member

@timbms The CI is failing because you've added a wrong submodule file. Please remove it.
Also, I noticed that you removed all @_disfavoredOverload, which is not correct. Again, please take a look at this comment.

Signed-off-by: Tim Müller-Seydlitz <timbms@gmail.com>
@timbms
Copy link
Contributor Author

timbms commented Sep 26, 2025

@StevenSorial: Please let me have the details of the failing Bitrise check. "1 successful check" is reported for Xcode Test for iOS (15.5).

@StevenSorial
Copy link
Member

@timbms it's a CI configuration issue. I will take care of it myself.

@timbms
Copy link
Contributor Author

timbms commented Sep 27, 2025

@StevenSorial Are you ready to merge the PR? When can we expect a release? Would be great.

@timbms timbms mentioned this pull request Sep 29, 2025
@StevenSorial StevenSorial merged commit 9941950 into SFSafeSymbols:stable Oct 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants