macOS: allow CMAKE_OSX_ARCHITECTURES to be arm64#1750
Merged
eXpl0it3r merged 1 commit intoSFML:masterfrom Mar 6, 2021
Merged
Conversation
Member
|
I'm not really sure, I'd say it's better to just drop the whole check, since you could also compile/build both architectures into the same file (although I haven't tried that yet with SFML). |
Contributor
Author
|
Actually, this will allow that as well. I've been distributing my MacOS app as a "universal app" which contains both architectures into a single binary (all static/dynamic libs also build into a single binary containing two architectures). |
eXpl0it3r
approved these changes
Mar 6, 2021
Member
eXpl0it3r
left a comment
There was a problem hiding this comment.
Verified on our brand new Mac Mini M1 🎉
ryandesign
referenced
this pull request
in macports/macports-ports
Mar 9, 2021
Add a patch to remove the check for x86_64 architecture in CMakeLists.txt allowing the package to build for arm64. Closes: https://trac.macports.org/ticket/62334 Signed-off-by: Rafael Kitover <rkitover@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed CMakeLists.txt to allow
CMAKE_OSX_ARCHITECTURESto be either x86_64, arm64, or both. This allows native builds on apple silicon.This PR is related to the issue #1749
Tasks
How to test this PR?
Pull the code on MacOS, enter some value into
CMAKE_OSX_ARCHITECTURES, and configure.