Window/Unix: fix SFML issue #1228, getPosition() returns incorrect results on Linux#1266
Closed
llongi wants to merge 1 commit intoSFML:masterfrom
llongi:master
Closed
Window/Unix: fix SFML issue #1228, getPosition() returns incorrect results on Linux#1266llongi wants to merge 1 commit intoSFML:masterfrom llongi:master
llongi wants to merge 1 commit intoSFML:masterfrom
llongi:master
Conversation
Member
|
It's a huge work that you've done, many thanks. I'm not a X11/WM expert, so here is my only comment: some parts or your patch don't follow our coding guidelines, you should fix them before we can merge your work. |
Member
|
Can you squash the two commits? |
…sults on Linux depending on the used WM, as well as not returning values that are in-sync with what was given to setPosition(x, y).
Contributor
Author
|
Squash done. |
binary1248
approved these changes
Aug 28, 2017
Member
|
Merged in 58b7c2c 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SFML issue #1228, getPosition() returns incorrect results on Linux depending on the used WM, as well as not returning values that are in-sync with what was given to setPosition(x, y).
See #1228 (comment) for a complete description of current patch, as well as testing results comparing current approach to approach in patch for over 20 different window managers.