[Behavior changes] Add blend mode to UIImage+Transform tint color API, default blend mode changed to sourceIn #3749
+206
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Naveen-C-Ramachandrappa
approved these changes
Sep 6, 2024
Contributor
Author
|
There are still some todo in some test case, I'll fix it and merge later |
fba7e54 to
e4dd492
Compare
Contributor
Author
Introduce the behavior changes:The default blend mode changed from |
3686d56 to
92ee70c
Compare
Also works for CIFilter variant
Update unit tests
92ee70c to
cf78e7e
Compare
…n` instead of `sourceAtop` This matches the Apple UIKit's naming and behavior
cf78e7e to
05e1840
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
I have added the required tests to prove the fix/feature I am adding
I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint)This merge request fixes / refers to the following issues: ...
Pull Request Description
This close #3748